Update build_summary_table function #578
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch update build_summary_table to match the same function in impala-shell. https://github.com/apache/impala/blob/a07bf84/shell/impala_client.py#L113 Testing: Run and pass following command ``` tox -- -ktest_build_summary_table ```
csringhofer
reviewed
Mar 14, 2025
impala/hiveserver2.py
Outdated
| setattr(agg_stats, attr, getattr(agg_stats, attr) + val) | ||
| setattr(max_stats, attr, max(getattr(max_stats, attr), val)) | ||
|
|
||
| if node.exec_stats is not None and node.exec_stats: |
There was a problem hiding this comment.
wouldn't be simply if node.exec_stats: enough?
There was a problem hiding this comment.
Replaced this with a new exec_summary.py from apache/impala@e73e2d4
impala/hiveserver2.py
Outdated
| memory_used = max_stats.memory_used | ||
| memory_est = est_stats.memory_used | ||
| if (is_prettyprint): | ||
| avg_time = prettyprint_time(avg_time) |
There was a problem hiding this comment.
probably it would be better to do it in another commit, but I think that formatting could be move to another file logic, e.g. exec_summary.py
There was a problem hiding this comment.
Done. Copy from apache/impala@e73e2d4
impala/tests/test_impala.py
Outdated
| '{0}.{1} a'.format(tmp_db_lower, empty_table)], | ||
| ] | ||
| validate_summary_table(output_dop_0, expected_dop_0) | ||
| cur.close_operation() |
There was a problem hiding this comment.
cur.close_operation() is not needed, execute() (and the cur fixture after the test is finished) will call it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch update build_summary_table to match the same function in impala-shell.
https://github.com/apache/impala/blob/a07bf84/shell/impala_client.py#L113
Testing:
Run and pass following command